Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22293 )
Change subject: IMPALA-13627: Handle legacy Hive timezone conversion ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/22293/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22293/3//COMMIT_MSG@37 PS3, Line 37: in Impala's behavior > thx for the benchmarks, it is less horrible than what I guessed - can you a Done http://gerrit.cloudera.org:8080/#/c/22293/3/be/src/exec/parquet/parquet-common.h File be/src/exec/parquet/parquet-common.h: http://gerrit.cloudera.org:8080/#/c/22293/3/be/src/exec/parquet/parquet-common.h@815 PS3, Line 815: /// If timestamp t >= v before conversion, then this function converts v in such a : /// way that the same will be true after t is converted. : void ConvertMinStatToLocalTime(TimestampValue* v) const; : : /// If timestamp t <= v before conversion, then this function converts v in such a : /// way that the same will be true after t is converted. : void ConvertMaxStatToLocalTime(TimestampValue* v) const; > Right. There are a couple timezones that switched across the day line (Paci Done http://gerrit.cloudera.org:8080/#/c/22293/3/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/22293/3/be/src/service/impala-server.cc@362 PS3, Line 362: use_local_tz_for_unix_timestamp_conv > Reminds me I need to add documentation for the new query option. Done -- To view, visit http://gerrit.cloudera.org:8080/22293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1271ed1da0b74366ab8315e7ec2d4ee47111e067 Gerrit-Change-Number: 22293 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 16 Jan 2025 22:04:54 +0000 Gerrit-HasComments: Yes
