Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22293 )
Change subject: IMPALA-13627: Handle legacy Hive timezone conversion ...................................................................... Patch Set 5: (4 comments) I still need to document the query option and figure out how to handle min/max. http://gerrit.cloudera.org:8080/#/c/22293/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22293/3//COMMIT_MSG@37 PS3, Line 37: impact on performance > Ack Done http://gerrit.cloudera.org:8080/#/c/22293/3/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/22293/3/common/thrift/Frontend.thrift@1081 PS3, Line 1081: i32 > I think I was looking at what Boost would accept, not what Calendar could g Done http://gerrit.cloudera.org:8080/#/c/22293/3/tests/query_test/test_hive_timestamp_conversion.py File tests/query_test/test_hive_timestamp_conversion.py: http://gerrit.cloudera.org:8080/#/c/22293/3/tests/query_test/test_hive_timestamp_conversion.py@52 PS3, Line 52: : def test_hive_313(self, vector, unique_database): : """The parquet file was written with Hive 3.1.3 using the new Date/Time APIs : (legacy=false) to convert from US/Pacific to UTC. The presence of writer.time.zone in : the metadata of the file allow us to infer that new Date/Time API > There are some convenience functions to do this, see create_table_and_copy_ Done http://gerrit.cloudera.org:8080/#/c/22293/3/tests/query_test/test_hive_timestamp_conversion.py@62 PS3, Line 62: create_table_from_parquet( > optional: I would prefer moving these tests to a .test file (and merge the Done -- To view, visit http://gerrit.cloudera.org:8080/22293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1271ed1da0b74366ab8315e7ec2d4ee47111e067 Gerrit-Change-Number: 22293 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 16 Jan 2025 00:58:14 +0000 Gerrit-HasComments: Yes
