Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/22130 )
Change subject: IMPALA-13565: Add general AI platform support to ai_generate_text ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/22130/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22130/4//COMMIT_MSG@18 PS4, Line 18: auth_credential to support passing the plain text as a token. maybe rephrase this to "support passing both plain text and jceks encrypted secrets" http://gerrit.cloudera.org:8080/#/c/22130/4//COMMIT_MSG@23 PS4, Line 23: token_method Should we rename this to something more generic like "credential_type"? There will also be room for extending this to future credentials like cloud provider secrets. enum class CREDENTIAL_TYPE { /// Input credentials will be treated as plain text. PLAIN, /// Input credentials will be treated as a jceks secret. JCEKS }; http://gerrit.cloudera.org:8080/#/c/22130/4/be/src/exprs/ai-functions.h File be/src/exprs/ai-functions.h: http://gerrit.cloudera.org:8080/#/c/22130/4/be/src/exprs/ai-functions.h@73 PS4, Line 73: /// credential and optional params. We should probably update comments to explain difference between 'params' and 'impala_options', might make sense to rename them to 'platform_params' and 'impala_options' so that these are more descriptive and we could add a comment like: " platform_params (optional) are additional AI platform specific parameters included in the request sent to the AI model impala_options (optional) are Impala API specific options i.e AiFunctionsOptions " http://gerrit.cloudera.org:8080/#/c/22130/4/be/src/udf/udf.h File be/src/udf/udf.h: http://gerrit.cloudera.org:8080/#/c/22130/4/be/src/udf/udf.h@80 PS4, Line 80: StringVal (*ai_generate_text2)(FunctionContext* context, const StringVal& endpoint, We're adding a new built in function? Shouldn't we just extend the existing "ai_generate_text"? -- To view, visit http://gerrit.cloudera.org:8080/22130 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ea2e1946089f262dda7ace73d5f7e37a5c98b14 Gerrit-Change-Number: 22130 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward (801) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Sun, 12 Jan 2025 14:57:26 +0000 Gerrit-HasComments: Yes
