Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22130 )
Change subject: IMPALA-13565: Add general AI platform support to ai_generate_text ...................................................................... Patch Set 4: (7 comments) Thanks Abhishek for the review. http://gerrit.cloudera.org:8080/#/c/22130/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22130/3//COMMIT_MSG@7 PS3, Line 7: IMPALA-13565: Add general AI platform support to ai_generate_text > Maybe reword this to "Add general AI platform support to ai_generate_text" Done http://gerrit.cloudera.org:8080/#/c/22130/3//COMMIT_MSG@12 PS3, Line 12: ai_api_additional_platforms, allowing Impala to access additional > Should we rename "ai_api_additional_sites" to "ai_api_additional_platforms" Done http://gerrit.cloudera.org:8080/#/c/22130/3/be/src/exprs/ai-functions-ir.cc File be/src/exprs/ai-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/22130/3/be/src/exprs/ai-functions-ir.cc@90 PS3, Line 90: */ > typo: Done http://gerrit.cloudera.org:8080/#/c/22130/3/be/src/exprs/ai-functions.h File be/src/exprs/ai-functions.h: http://gerrit.cloudera.org:8080/#/c/22130/3/be/src/exprs/ai-functions.h@54 PS3, Line 54: UNSUPPORTED, > Maybe skip the '_STANDARD' i.e Done http://gerrit.cloudera.org:8080/#/c/22130/3/be/src/exprs/ai-functions.inline.h File be/src/exprs/ai-functions.inline.h: http://gerrit.cloudera.org:8080/#/c/22130/3/be/src/exprs/ai-functions.inline.h@91 PS3, Line 91: } > Instead of creating a local Document here we can pass Document reference fr Adds the impala options as a new parameter to the ai_generate_text, may reduce some overhead parsing the strings, and use a string_view for the payload. But for the payload, it needs to be passed to curl.PostToURL() as a string, so anyway we need to construct a new string for it. http://gerrit.cloudera.org:8080/#/c/22130/3/be/src/exprs/ai-functions.inline.h@111 PS3, Line 111: IMPALA_AI_API_STANDARD_OPENAI_LEN) != nullptr) { > Should the comparison be case insensitive? Changed to use gstrncasestr() for case insensitive http://gerrit.cloudera.org:8080/#/c/22130/3/be/src/exprs/ai-functions.inline.h@162 PS3, Line 162: LOG(WARNING) << AI_GENERATE_TXT_JSON_PARSE_ERROR << ": " << e.what(); > Technically speaking a 'token' is also a secret and we could also support r Adds a new option token_method to control the plain text. -- To view, visit http://gerrit.cloudera.org:8080/22130 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ea2e1946089f262dda7ace73d5f7e37a5c98b14 Gerrit-Change-Number: 22130 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward (801) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 10 Jan 2025 13:41:24 +0000 Gerrit-HasComments: Yes
