Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22036 )
Change subject: IMPALA-13518: Show target name of COMMIT_TXN events in logs ...................................................................... IMPALA-13518: Show target name of COMMIT_TXN events in logs The message of a COMMIT_TXN event just contains the transaction id (txnid). In the logs of top-10 expensive events and top-10 targets that contribute to the lag, we show the target as CLUSTER_WIDE. However, when processing the events, catalogd actually finds the involved tables and reloads them. It'd be helpful to show the names of the tables involved in the transaction. This patch overrides the getTargetName() method in CommitTxnEvent to show the table names. They are collected after the event is processed. Tests: - Add tests in MetastoreEventsProcessorTest Change-Id: I4a7cb5e716453290866a4c3e74c0d269f621144f Reviewed-on: http://gerrit.cloudera.org:8080/22036 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Csaba Ringhofer <[email protected]> Reviewed-by: Sai Hemanth Gantasala <[email protected]> Reviewed-by: Michael Smith <[email protected]> --- M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java 3 files changed, 117 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Verified Csaba Ringhofer: Looks good to me, but someone else must approve Sai Hemanth Gantasala: Looks good to me, but someone else must approve Michael Smith: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/22036 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4a7cb5e716453290866a4c3e74c0d269f621144f Gerrit-Change-Number: 22036 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
