Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22036 )
Change subject: IMPALA-13518: Show target name of COMMIT_TXN events in logs ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/22036/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22036/3//COMMIT_MSG@7 PS3, Line 7: COMMIT_TXN > Could this be also useful for abort? Or that should be always fast? I'm afraid not. Processing ABORT_TXN events don't trigger external RPCs so it's usually fast. We haven't seen slow ABORT_TXN events yet. http://gerrit.cloudera.org:8080/#/c/22036/3/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/22036/3/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@853 PS3, Line 853: if (tableNames_.isEmpty()) return CLUSTER_WIDE_TARGET; > Ack Note that we have two MetastoreShim.java files based on different Hive versions (CDP Hive vs. Apache Hive3): * fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java * fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java It's configured here which one to use: https://github.com/apache/impala/blob/777ae104bb1f5e5e0f8d19bd26886fef8084453c/fe/pom.xml#L811 Ideally we should move back CommitTxnEvent to MetastoreEvents.java (IMPALA-13285). That also helps in Apache Hive4 support (IMPALA-13647). -- To view, visit http://gerrit.cloudera.org:8080/22036 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a7cb5e716453290866a4c3e74c0d269f621144f Gerrit-Change-Number: 22036 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 07 Jan 2025 05:21:11 +0000 Gerrit-HasComments: Yes
