Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22223 )
Change subject: IMPALA-13617: Rename c_last_review_date to c_last_review_date_sk ...................................................................... IMPALA-13617: Rename c_last_review_date to c_last_review_date_sk TPC-DS v2.11.0, section 2.4.7, rename column customer.c_last_review_date to customer.c_last_review_date_sk to align with other surrogate key columns. impala-tpcds-kit has been modified to reflect this column name change in https://github.com/cloudera/impala-tpcds-kit/commit/086d7113c8b4172247f83f60f4e274fe3326df11 However, the tpcds dataset schema in Impala test data remains unchanged. This patch did such a rename to align closer to TPC-DS v2.11.0. This patch contains no data type adjustment because such adjustment requires larger changes. customer_multiblock_page_index.parquet added by IMPALA-10310 is regenerated to follow the new schema of table customer. The SQL used to create the file is ordered more specifically over both c_current_cdemo_sk and c_customer_sk columns. The associated test assertion in parquet-page-index.test is also updated. A workaround in test_file_parser.py added by IMPALA-13543 is now removed after this change is applied. Testing: - Pass core tests. Change-Id: Ie446b3c534cb8f6f54265cd9b2f705cad91dd4ac Reviewed-on: http://gerrit.cloudera.org:8080/22223 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M docker/quickstart_client/load_tpcds_kudu.sql M docker/quickstart_client/load_tpcds_parquet.sql M docs/topics/impala_show.xml M docs/topics/impala_tutorial.xml M testdata/data/README M testdata/data/customer_multiblock_page_index.parquet M testdata/datasets/tpcds/tpcds_jdbc_schema_template.sql M testdata/datasets/tpcds/tpcds_kudu_template.sql M testdata/datasets/tpcds/tpcds_schema_template.sql M testdata/datasets/tpcds_partitioned/tpcds_partitioned_schema_template.sql M testdata/workloads/functional-planner/queries/PlannerTest/fk-pk-join-detection.test M testdata/workloads/functional-planner/queries/PlannerTest/tpcds/tpcds-q30.test M testdata/workloads/functional-query/queries/QueryTest/parquet-page-index.test M testdata/workloads/tpcds-unmodified/queries/tpcds-q30.test M testdata/workloads/tpcds/queries/raw/tpcds-query30.sql M testdata/workloads/tpcds/queries/tpcds-decimal_v2-q30.test M testdata/workloads/tpcds/queries/tpcds-q30.test M tests/util/test_file_parser.py 18 files changed, 46 insertions(+), 46 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/22223 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie446b3c534cb8f6f54265cd9b2f705cad91dd4ac Gerrit-Change-Number: 22223 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
