Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22223 )

Change subject: IMPALA-13617: Rename c_last_review_date to c_last_review_date_sk
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22223/1/testdata/data/README
File testdata/data/README:

http://gerrit.cloudera.org:8080/#/c/22223/1/testdata/data/README@626
PS1, Line 626: SET parquet.page.row.count.limit=10;
> Seems like this setting was not effective.
Looks like it is passed by Hive to parquet-java library?
https://github.com/apache/parquet-java/blob/a3bfbcddd7e0d6953ed82b5bc170668cd16bea40/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java#L157

Might have no effect, but does not hurt to keep.



--
To view, visit http://gerrit.cloudera.org:8080/22223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie446b3c534cb8f6f54265cd9b2f705cad91dd4ac
Gerrit-Change-Number: 22223
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Thu, 19 Dec 2024 15:45:56 +0000
Gerrit-HasComments: Yes

Reply via email to