Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 13: (5 comments) http://gerrit.cloudera.org:8080/#/c/21930/9/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/21930/9/be/src/service/client-request-state.cc@2466 PS9, Line 2466: Status ClientRequestState::TryKillQueryLocally( > Thanks! Splitted it into TryKillQueryLocally() and TryKillQueryRemotely(). Done http://gerrit.cloudera.org:8080/#/c/21930/9/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/21930/9/be/src/service/impala-server.h@729 PS9, Line 729: class SecretArg; > This is because ClientRequestState::TryKillQueryLocally() needs to call two Done http://gerrit.cloudera.org:8080/#/c/21930/9/fe/src/main/java/org/apache/impala/analysis/StatementBase.java File fe/src/main/java/org/apache/impala/analysis/StatementBase.java: http://gerrit.cloudera.org:8080/#/c/21930/9/fe/src/main/java/org/apache/impala/analysis/StatementBase.java@280 PS9, Line 280: * This method is designed to allow custom authorization exception handling. A > Thanks! Added doc to explain it. Done http://gerrit.cloudera.org:8080/#/c/21930/13/fe/src/main/java/org/apache/impala/analysis/StatementBase.java File fe/src/main/java/org/apache/impala/analysis/StatementBase.java: http://gerrit.cloudera.org:8080/#/c/21930/13/fe/src/main/java/org/apache/impala/analysis/StatementBase.java@283 PS13, Line 283: prigvilege Nit: privilege http://gerrit.cloudera.org:8080/#/c/21930/13/tests/query_test/test_kill_query.py File tests/query_test/test_kill_query.py: http://gerrit.cloudera.org:8080/#/c/21930/13/tests/query_test/test_kill_query.py@89 PS13, Line 89: class TestKillQuery(ImpalaTestSuite): > I think this should be as exhaustive as tests/query_test/test_cancellation. I like this suggestion. It's worth trying. -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 13 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Wed, 18 Dec 2024 22:52:29 +0000 Gerrit-HasComments: Yes
