Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 13: (5 comments) I have not review the implementation detail, but want to give my initial feedback. http://gerrit.cloudera.org:8080/#/c/21930/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21930/13//COMMIT_MSG@15 PS13, Line 15: KILL QUERY '123:456'; Mention in commit message that we follow syntax from HIVE-17483. http://gerrit.cloudera.org:8080/#/c/21930/13/common/protobuf/control_service.proto File common/protobuf/control_service.proto: http://gerrit.cloudera.org:8080/#/c/21930/13/common/protobuf/control_service.proto@470 PS13, Line 470: optional string requesting_user = 2; Shoudn't this be required? http://gerrit.cloudera.org:8080/#/c/21930/13/tests/custom_cluster/test_kill_query_custom_cluster.py File tests/custom_cluster/test_kill_query_custom_cluster.py: http://gerrit.cloudera.org:8080/#/c/21930/13/tests/custom_cluster/test_kill_query_custom_cluster.py@76 PS13, Line 76: protocol = 'beeswax' Why not test both protocol everywhere using cls.ImpalaTestMatrix.add_dimension(create_client_protocol_dimension())? http://gerrit.cloudera.org:8080/#/c/21930/13/tests/query_test/test_kill_query.py File tests/query_test/test_kill_query.py: http://gerrit.cloudera.org:8080/#/c/21930/13/tests/query_test/test_kill_query.py@74 PS13, Line 74: : def assert_kill_ok(test_suite, client, query_id, user=None): : sql = "KILL QUERY '{0}'".format(query_id) : result = test_suite.execute_query_expect_success(client, sql, user=user) : assert len(result.data) == 1 : assert result.data[0] == "Query {0} is killed.".format(query_id) : : : def assert_kill_error(test_suite, client, error_msg, query_id=None, sql=None, user=None): : if sql is None: : sql = "KILL QUERY '{0}'".format(query_id) : exc = test_suite.execute_query_expect_failure(client, sql, user=user) : assert error_msg_expected(str(exc), error_msg) Move this under TestKillQuery. http://gerrit.cloudera.org:8080/#/c/21930/13/tests/query_test/test_kill_query.py@89 PS13, Line 89: class TestKillQuery(ImpalaTestSuite): I think this should be as exhaustive as tests/query_test/test_cancellation.py. That test validate a lot more vector combinations. Can you replicate it, but replace the cancellation with KILL query? See also cancel_query_and_validate_state() in cancel_util.py. Maybe it is easier to implement KILL as an option to cancel query within cancel_query_and_validate_state() and let test_cancellation.py define one more test vector to either cancel query through client or through KILL query. We'll probably see a behavior difference there. -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 13 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Wed, 18 Dec 2024 21:55:28 +0000 Gerrit-HasComments: Yes
