Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries in frontend ...................................................................... Patch Set 24: (7 comments) http://gerrit.cloudera.org:8080/#/c/21803/24//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21803/24//COMMIT_MSG@25 PS24, Line 25: Adds periodic checks to the planning process to interrupt planning. : They're primarily useful when planning is waiting on catalogd/HMS. If : planning gets into an algorithmically complex operation, it will not be : interrupted. To me, combining this paragraph with the paragraph about "Removes check_inflight" would help clarify the cancellation process. Reading this paragraph by itself seems to indicate queries will not be cancelled at all when a cancel is requested during an algorithmically complex frontend operation. http://gerrit.cloudera.org:8080/#/c/21803/24/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/21803/24/be/src/service/client-request-state.cc@246 PS24, Line 246: RETURN_IF_CANCELLED(this); Nit: A comment here about how the client request state got into cancelled mode would be helpful. http://gerrit.cloudera.org:8080/#/c/21803/24/be/src/service/client-request-state.cc@1155 PS24, Line 1155: RETURN_IF_CANCELLED(this); Nit: A comment here about how the client request state got into cancelled mode would be helpful. http://gerrit.cloudera.org:8080/#/c/21803/24/be/src/service/fe-support.cc File be/src/service/fe-support.cc: http://gerrit.cloudera.org:8080/#/c/21803/24/be/src/service/fe-support.cc@592 PS24, Line 592: if (!request.__isset.header) { If the request header is set, does that guarantee the header's query_id will also be set or do we need to set the query id every time GetThreadDebugInfo() returns non-nullptr? http://gerrit.cloudera.org:8080/#/c/21803/24/fe/src/main/java/org/apache/impala/catalog/CatalogCancelledException.java File fe/src/main/java/org/apache/impala/catalog/CatalogCancelledException.java: http://gerrit.cloudera.org:8080/#/c/21803/24/fe/src/main/java/org/apache/impala/catalog/CatalogCancelledException.java@26 PS24, Line 26: public class CatalogCancelledException extends CatalogException { How easy is it to identify the query id for which this exception is thrown? If it's not inherently easy, I suggest adding the query id as a parameter to the constructor and including that query id in the message. http://gerrit.cloudera.org:8080/#/c/21803/24/fe/src/main/java/org/apache/impala/common/CancelledException.java File fe/src/main/java/org/apache/impala/common/CancelledException.java: http://gerrit.cloudera.org:8080/#/c/21803/24/fe/src/main/java/org/apache/impala/common/CancelledException.java@23 PS24, Line 23: public class CancelledException extends ImpalaException { How easy is it to identify the query id for which this exception is thrown? If it's not inherently easy, I suggest adding the query id as a parameter to the constructor and including that query id in the message. http://gerrit.cloudera.org:8080/#/c/21803/24/fe/src/main/java/org/apache/impala/service/Canceller.java File fe/src/main/java/org/apache/impala/service/Canceller.java: http://gerrit.cloudera.org:8080/#/c/21803/24/fe/src/main/java/org/apache/impala/service/Canceller.java@47 PS24, Line 47: // TODO: use thread-local storage Will this todo be resolved before this change is submitted? If not, please open a Jira to tackle it. -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 24 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Mon, 16 Dec 2024 21:00:04 +0000 Gerrit-HasComments: Yes
