Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries in frontend ...................................................................... Patch Set 23: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/21803/23/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/21803/23/be/src/catalog/catalog-server.cc@458 PS23, Line 458: VLOG_RPC << "Cancel(): request=" << ThriftDebugString(req); Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead. http://gerrit.cloudera.org:8080/#/c/21803/23/be/src/catalog/catalog-server.cc@467 PS23, Line 467: VLOG_RPC << "Cancel(): response=" << ThriftDebugStringNoThrow(resp); Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead. http://gerrit.cloudera.org:8080/#/c/21803/23/common/thrift/CatalogService.thrift File common/thrift/CatalogService.thrift: PS23: This file is used in communication between impalad and catalogd/statestore. Please make sure impalads can still work with new/old versions of catalogd and statestore. Basically only new optional fields can be added. http://gerrit.cloudera.org:8080/#/c/21803/23/common/thrift/CatalogService.thrift@761 PS23, Line 761: 1: required CatalogServiceVersion protocol_version = CatalogServiceVersion.V2 Modifying/adding this required field might break the compatibility between impalad and catalogd/statestore during upgrade -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 23 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 12 Dec 2024 22:41:04 +0000 Gerrit-HasComments: Yes
