Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21474 )
Change subject: IMPALA-13123: Add option to run tests with Python 3 ...................................................................... Patch Set 11: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/21474/11/tests/conftest.py File tests/conftest.py: http://gerrit.cloudera.org:8080/#/c/21474/11/tests/conftest.py@199 PS11, Line 199: l flake8: E741 ambiguous variable name 'l' http://gerrit.cloudera.org:8080/#/c/21474/11/tests/query_test/test_parquet_page_index.py File tests/query_test/test_parquet_page_index.py: http://gerrit.cloudera.org:8080/#/c/21474/11/tests/query_test/test_parquet_page_index.py@183 PS11, Line 183: a flake8: W504 line break after binary operator -- To view, visit http://gerrit.cloudera.org:8080/21474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I177d9b8eae9b99ba536ca5c598b07208c3887f8c Gerrit-Change-Number: 21474 Gerrit-PatchSet: 11 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 14 Dec 2024 00:03:45 +0000 Gerrit-HasComments: Yes
