Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21474 )
Change subject: IMPALA-13123: Add option to run tests with Python 3 ...................................................................... Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/21474/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21474/10//COMMIT_MSG@9 PS10, Line 9: IMPALA_USE_PYTHON3_TESTS > What happen if I run any tests under tests/shell/ with IMPALA_USE_PYTHON3_T Shell tests have two different pythons involved. There is the python used to run pytest, but then the pytest invokes impala-shell as a separate process with a configurable python version. This environment variable affects the pytest's python, but it doesn't impact the python used to invoke impala-shell as a commandline program. So, it is still testing impala-shell with python 2 and 3. http://gerrit.cloudera.org:8080/#/c/21474/10//COMMIT_MSG@17 PS10, Line 17: - Eliminating 'basestring' and 'unicode' locations by using : the recommendations from future : ( https://python-future.org/compatible_idioms.html#basestring and : https://python-future.org/compatible_idioms.html#unicode ) > What about occurrences in shell/ like this? shell/ already works properly with Python 3. It's uses of basestring and unicode are done in a way that is compatible. The code in compatability.py is handling basestring differences properly. The other uses of "unicode" are in locations where it checks that it is using python 2. I changed this to say I'm eliminating those locations in the tests/ directory. http://gerrit.cloudera.org:8080/#/c/21474/10/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/21474/10/tests/common/impala_test_suite.py@1445 PS10, Line 1445: e > flake8: F841 local variable 'e' is assigned to but never used Done http://gerrit.cloudera.org:8080/#/c/21474/10/tests/run-tests.py File tests/run-tests.py: http://gerrit.cloudera.org:8080/#/c/21474/10/tests/run-tests.py@1 PS10, Line 1: #!/usr/bin/env impala-env-versioned-python > Perhaps load-data.py, generate-schema-statements.py, and single_node_perf_r Since these are running as separate scripts / separate processes, we have the freedom to do them independently. start-impala-cluster.py works with python 3, so I switched it over to impala-python3. Many things are still broken due to IMPALA-11980, and load-data.py is one of them. I will switch it over as a separate change to make dataload use Python 3 (and that would also cover generate-schema-statements.py). I'll start testing single_node_perf_run.py once this goes in. -- To view, visit http://gerrit.cloudera.org:8080/21474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I177d9b8eae9b99ba536ca5c598b07208c3887f8c Gerrit-Change-Number: 21474 Gerrit-PatchSet: 10 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 14 Dec 2024 00:02:54 +0000 Gerrit-HasComments: Yes
