Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/22124 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding ...................................................................... Patch Set 7: (2 comments) Nice patch, Gabriella! http://gerrit.cloudera.org:8080/#/c/22124/7/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py File testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py: http://gerrit.cloudera.org:8080/#/c/22124/7/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@25 PS7, Line 25: floats = pa.array([1.45, 4.256, 6.3573, 4.235] I suppose you intend to reuse the generated files for positive tests later. Can you please add some more values, so that the total is at least 7-10? http://gerrit.cloudera.org:8080/#/c/22124/7/tests/query_test/test_parquet_encodings.py File tests/query_test/test_parquet_encodings.py: http://gerrit.cloudera.org:8080/#/c/22124/7/tests/query_test/test_parquet_encodings.py@50 PS7, Line 50: temp Could you give a more descriptive table name like "parquet_byte_stream_split" or something that refers to its content and what it tests? -- To view, visit http://gerrit.cloudera.org:8080/22124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5eff8bf51fe246a9d0250e38c470b821fec75d9 Gerrit-Change-Number: 22124 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 03 Dec 2024 12:14:26 +0000 Gerrit-HasComments: Yes
