Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22124 )
Change subject: [WIP] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding ...................................................................... Patch Set 2: (14 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/22124/2/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py File testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py: http://gerrit.cloudera.org:8080/#/c/22124/2/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@27 PS2, Line 27: ' flake8: E501 line too long (115 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22124/2/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@32 PS2, Line 32: e flake8: E501 line too long (117 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22124/2/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@34 PS2, Line 34: flake8: W391 blank line at end of file http://gerrit.cloudera.org:8080/#/c/22124/2/tests/query_test/test_parquet_encodings.py File tests/query_test/test_parquet_encodings.py: http://gerrit.cloudera.org:8080/#/c/22124/2/tests/query_test/test_parquet_encodings.py@29 PS2, Line 29: T flake8: E303 too many blank lines (2) http://gerrit.cloudera.org:8080/#/c/22124/2/tests/query_test/test_parquet_encodings.py@29 PS2, Line 29: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/22124/2/tests/query_test/test_parquet_encodings.py@42 PS2, Line 42: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/22124/2/tests/query_test/test_parquet_encodings.py@42 PS2, Line 42: self._parquet_byte_stream_split_encoding_helper(vector, unique_database, "float", line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22124/2/tests/query_test/test_parquet_encodings.py@46 PS2, Line 46: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/22124/2/tests/query_test/test_parquet_encodings.py@46 PS2, Line 46: self._parquet_byte_stream_split_encoding_helper(vector, unique_database, "double", line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22124/2/tests/query_test/test_parquet_encodings.py@49 PS2, Line 49: f flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22124/2/tests/query_test/test_parquet_encodings.py@51 PS2, Line 51: s flake8: E501 line too long (115 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22124/2/tests/query_test/test_parquet_encodings.py@52 PS2, Line 52: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/22124/2/tests/query_test/test_parquet_encodings.py@52 PS2, Line 52: create_table_and_copy_files(self.client, create_stmt, unique_database, table_name, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22124/2/tests/query_test/test_parquet_encodings.py@57 PS2, Line 57: flake8: W391 blank line at end of file -- To view, visit http://gerrit.cloudera.org:8080/22124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5eff8bf51fe246a9d0250e38c470b821fec75d9 Gerrit-Change-Number: 22124 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 26 Nov 2024 14:52:12 +0000 Gerrit-HasComments: Yes
