Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22006 )
Change subject: IMPALA-13503: CustomClusterTestSuite for whole class ...................................................................... Patch Set 10: Code-Review+2 > Yes, they're pre-existing and unrelated. I ran a DEBUG build and those tests > passed: > https://jenkins.impala.io/view/Ubuntu%2020/job/ubuntu-20.04-from-scratch/3797/. There are couple of code like this in test_scratch_disk.py handle = self.execute_query_async_using_client(client, self.spill_query, vector) verifier = MetricVerifier(impalad.service) verifier.wait_for_metric("impala-server.num-fragments-in-flight", 2) Maybe they should be reordered such that verifier instantiation happen before query exec. verifier = MetricVerifier(impalad.service) handle = self.execute_query_async_using_client(client, self.spill_query, vector) verifier.wait_for_metric("impala-server.num-fragments-in-flight", 2) Lets monitor that if it happen again. -- To view, visit http://gerrit.cloudera.org:8080/22006 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a08694edcf8cc340d89a0fb33beb8229163b356 Gerrit-Change-Number: 22006 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 14 Nov 2024 22:18:52 +0000 Gerrit-HasComments: No
