Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22006 )

Change subject: IMPALA-13503: CustomClusterTestSuite for whole class
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22006/10/tests/custom_cluster/test_tuple_cache.py
File tests/custom_cluster/test_tuple_cache.py:

http://gerrit.cloudera.org:8080/#/c/22006/10/tests/custom_cluster/test_tuple_cache.py@33
PS10, Line 33: --tuple_cache_dir=/tmp
> nit: Is it possible to hook this with tmp dir management through tmp_dir_pl
Yes, though not really a big deal. Contents aren't re-used across clusters, and 
it'll get cleaned up on restart.



--
To view, visit http://gerrit.cloudera.org:8080/22006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a08694edcf8cc340d89a0fb33beb8229163b356
Gerrit-Change-Number: 22006
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Thu, 14 Nov 2024 21:31:03 +0000
Gerrit-HasComments: Yes

Reply via email to