Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21616 )
Change subject: IMPALA-12345: Add user quotas to Admission Control ...................................................................... Patch Set 20: (1 comment) Thank you Andrew for addressing my comments. I only have 1 nit left. http://gerrit.cloudera.org:8080/#/c/21616/20/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/21616/20/tests/custom_cluster/test_admission_controller.py@2481 PS20, Line 2481: self.wait_on_queries_page_num_queued(0, 0) nit: After this, can you check that all admission-controller.agg-current-users.* and admission-controller.local-current-users.* is empty? I assume some test method that set fs_allocation_file parameter will have User Quota feature enabled? -- To view, visit http://gerrit.cloudera.org:8080/21616 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c33f3f2427db57fb9b6c593a4b22d5029549b41 Gerrit-Change-Number: 21616 Gerrit-PatchSet: 20 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 14 Nov 2024 18:56:27 +0000 Gerrit-HasComments: Yes
