Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21616 )
Change subject: IMPALA-12345: Add user quotas to Admission Control ...................................................................... Patch Set 18: (3 comments) http://gerrit.cloudera.org:8080/#/c/21616/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21616/18//COMMIT_MSG@75 PS18, Line 75: Riza small fixes Should probably remove this line. http://gerrit.cloudera.org:8080/#/c/21616/18/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/21616/18/be/src/scheduling/admission-controller.h@482 PS18, Line 482: PerUserTracking( nit: this constructor is unnecessary, using initializer syntax for a struct has the same effect PerUserTracking{user, was_queued, track_per_user} https://en.cppreference.com/w/cpp/language/aggregate_initialization http://gerrit.cloudera.org:8080/#/c/21616/18/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/21616/18/be/src/scheduling/admission-controller.cc@80 PS18, Line 80: DEFINE_string(injected_group_members_debug_only, "", Seems like this should be DEFINE_string_hidden. -- To view, visit http://gerrit.cloudera.org:8080/21616 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c33f3f2427db57fb9b6c593a4b22d5029549b41 Gerrit-Change-Number: 21616 Gerrit-PatchSet: 18 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 07 Nov 2024 22:49:07 +0000 Gerrit-HasComments: Yes
