Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22024 )
Change subject: IMPALA-13482: Bug fixes for lag/coalesce in analytic function. ...................................................................... IMPALA-13482: Bug fixes for lag/coalesce in analytic function. The following SQL query in analytics.test ... select lag(coalesce(505, 1 + NULL), 1) over (order by int_col desc) from alltypestiny ... had a couple of issues 1) The coalesce function needed a special operator. This function derives its return type from a common type that works for all parameters. 2) The function was not being saved when being reset. This is needed for when resetAnalysisState is called. 3) createNullLiteral needed to be overriden for similar reasons. The null literal type needs to be saved for when resetAnalysisState is called. Change-Id: Ic54d955a73cec4b5f421099a74df4172a1b7dd8b Reviewed-on: http://gerrit.cloudera.org:8080/22024 Reviewed-by: Impala Public Jenkins <[email protected]> Reviewed-by: Michael Smith <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedAnalyticExpr.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedFunctionCallExpr.java A java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCoalesceFunction.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCustomOperatorTable.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaOperatorTable.java 5 files changed, 65 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified Michael Smith: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/22024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic54d955a73cec4b5f421099a74df4172a1b7dd8b Gerrit-Change-Number: 22024 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]>
