Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22024 )
Change subject: IMPALA-13482: Bug fixes for lag/coalesce in analytic function. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22024/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCoalesceFunction.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCoalesceFunction.java: http://gerrit.cloudera.org:8080/#/c/22024/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCoalesceFunction.java@30 PS2, Line 30: * Implementation of coalesce which needs generates a return type > nit: "needs generates"? Done -- To view, visit http://gerrit.cloudera.org:8080/22024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic54d955a73cec4b5f421099a74df4172a1b7dd8b Gerrit-Change-Number: 22024 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 07 Nov 2024 14:55:31 +0000 Gerrit-HasComments: Yes
