Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21866 )
Change subject: IMPALA-13415: Add a special testing mode to track Calcite progress ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/21866/9/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/21866/9/tests/common/impala_test_suite.py@879 PS9, Line 879: os.makedirs(output_directory) > Sounds good. Still a preference thing on my part, but I'm ok with it. Ok, one more small argument because this JUST happened to me. I created a directory outside of the structure. I specified a directory but spelled it differently (actually, I missed a layer). A new directory was created rather than placing it in the directory I wanted it go into. Again, not gonna stop this because I don't think it's a big deal, but this is why I think it's a good idea if the directory is specified, it should fail because I'm telling you where I want it to go. -- To view, visit http://gerrit.cloudera.org:8080/21866 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I453c219c22b6cbc253574e0467d2c0d7b1fac092 Gerrit-Change-Number: 21866 Gerrit-PatchSet: 9 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 07 Nov 2024 21:08:21 +0000 Gerrit-HasComments: Yes
