Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21866 )
Change subject: IMPALA-13415: Add a special testing mode to track Calcite progress ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/21866/9/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/21866/9/tests/common/impala_test_suite.py@879 PS9, Line 879: os.makedirs(output_directory) > What do you mean outside its control? Idk. I mean, if it's created under the Impala directory in the default spot, I fully expect the directory to be created. But under a user given spot that is supplied seems like you're asking it to do something that it wasn't intended to. It creates its own permissions, and potentially under a different user ID than intended. You can say that the log file itself has the same issue, but a directory seems a bit heavier to me. Personal opinion, that's all. Not a big deal if no one else agrees. -- To view, visit http://gerrit.cloudera.org:8080/21866 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I453c219c22b6cbc253574e0467d2c0d7b1fac092 Gerrit-Change-Number: 21866 Gerrit-PatchSet: 9 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 04 Nov 2024 23:25:56 +0000 Gerrit-HasComments: Yes
