Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21142 )
Change subject: IMPALA-12737: Query columns in workload management tables. ...................................................................... Patch Set 64: (3 comments) http://gerrit.cloudera.org:8080/#/c/21142/67/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/21142/67/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@4661 PS67, Line 4661: recursively walking > Maybe change into BFS instead of DFS. To me, recursion is easier to understand than a loop in non-tail recursion cases. I don't foresee any issues with stack overflow exceptions. Do you think we need to be concerned about those exceptions happening? What advantages would a BFS have over depth first? http://gerrit.cloudera.org:8080/#/c/21142/67/fe/src/main/java/org/apache/impala/analysis/Path.java File fe/src/main/java/org/apache/impala/analysis/Path.java: http://gerrit.cloudera.org:8080/#/c/21142/67/fe/src/main/java/org/apache/impala/analysis/Path.java@513 PS67, Line 513: currentType = rootDesc_.getType(); > There are many nullable fields around SlotRef, SlotDesc, Path, TupleDesc, e That would definitely be helpful. http://gerrit.cloudera.org:8080/#/c/21142/64/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/21142/64/tests/common/impala_test_suite.py@1419 PS64, Line 1419: wait_for_log_exists > Or disable it entirely, I tried turning off log buffering, and it did not speed up the tests at all. Thus, I am not going to tackle this change in this patch. Another patch for sure though. -- To view, visit http://gerrit.cloudera.org:8080/21142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78f3670b067c0c192ee8a212fba95466fbcb51d7 Gerrit-Change-Number: 21142 Gerrit-PatchSet: 64 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 31 Oct 2024 16:02:12 +0000 Gerrit-HasComments: Yes
