Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21142 )
Change subject: IMPALA-12737: Query columns in workload management tables. ...................................................................... Patch Set 67: Code-Review+2 (2 comments) Considering that ps67 has pass DRY_RUN, I don't mind deferring my latest comments as follow up patch. http://gerrit.cloudera.org:8080/#/c/21142/67/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/21142/67/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@4661 PS67, Line 4661: recursively walking > To me, recursion is easier to understand than a loop in non-tail recursion Stack overflow is exactly what I'm worried about. Nested views can be very wild in production. I assume, if user do hit stack overflow, their only option is to disable WM entirely. That can be an improvement patch that separate from this. http://gerrit.cloudera.org:8080/#/c/21142/67/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@4699 PS67, Line 4699: .getCanonicalPath() : .subList(0, 3) > I think it is clearer to create new method in Path class with intention of I'm also OK deferring this as follow up patch. -- To view, visit http://gerrit.cloudera.org:8080/21142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78f3670b067c0c192ee8a212fba95466fbcb51d7 Gerrit-Change-Number: 21142 Gerrit-PatchSet: 67 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 31 Oct 2024 16:21:42 +0000 Gerrit-HasComments: Yes
