Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21961 )
Change subject: IMPALA-13468: Fix various aggregation issues in aggregation.test ...................................................................... Patch Set 5: Ok, so I ran tpcds q45 through the regression tests with this patch and it did show up as PASSED For completeness, I also cut and paste your query into impala-shell after issuing a "use tpcds" command and this also worked fine. So I'm not sure where the discrepancy is. Judging by the error though? I think you might not have the latest code? Maybe there's a patch missing? I think the COUNT issue might have been resolved by this patch: commit 4289fa1a166de6a77d4a41e7387340b18f9fc08c Author: Steve Carlin <[email protected]> Date: Fri Oct 4 11:12:48 2024 -0700 IMPALA-13197: (part 2) Added Analytic Expressions to Calcite Planner By this line in ImpalaCustomOperatorTable: 4289fa1a166 (Steve Carlin 2024-10-04 11:12:48 -0700 203) public static final SqlAggFunction COUNT = 4289fa1a166 (Steve Carlin 2024-10-04 11:12:48 -0700 204) new SqlCountAggFunction("COUNT", OperandTypes.VARIADIC); -- To view, visit http://gerrit.cloudera.org:8080/21961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I038127d6a2f228ae8d263e983b1906e99ae05f77 Gerrit-Change-Number: 21961 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 23 Oct 2024 12:49:42 +0000 Gerrit-HasComments: No
