Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21961 )
Change subject: IMPALA-13468: Fix various aggregation issues in aggregation.test ...................................................................... Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/21961/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAggOperator.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAggOperator.java: http://gerrit.cloudera.org:8080/#/c/21961/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAggOperator.java@32 PS3, Line 32: ImpalaOperator > This says ImpalaOperator but the actual class is ImpalaAggOperator. Is Imp Bad cut and paste. No, ImpalaAggOperator needs to extend SqlAggFunction for Calcite to acknowledge it is agg http://gerrit.cloudera.org:8080/#/c/21961/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAvgAggFunction.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAvgAggFunction.java: http://gerrit.cloudera.org:8080/#/c/21961/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAvgAggFunction.java@31 PS3, Line 31: TIMESTMP > typo: TIMESTAMP Done http://gerrit.cloudera.org:8080/#/c/21961/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaGroupingIdFunction.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaGroupingIdFunction.java: http://gerrit.cloudera.org:8080/#/c/21961/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaGroupingIdFunction.java@21 PS3, Line 21: import com.google.common.base.Preconditions; > Most of these imported classes are not used in this file. Done http://gerrit.cloudera.org:8080/#/c/21961/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaGroupingIdFunction.java@67 PS3, Line 67: /** : */ > nit: remove empty comments Done http://gerrit.cloudera.org:8080/#/c/21961/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaMinMaxAggFunction.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaMinMaxAggFunction.java: http://gerrit.cloudera.org:8080/#/c/21961/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaMinMaxAggFunction.java@31 PS3, Line 31: SqlAvgAggFunction > Confused by the mention of SqlAvgAgg since the class is doing MinMax, not A Done http://gerrit.cloudera.org:8080/#/c/21961/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaMinMaxAggFunction.java@31 PS3, Line 31: TIMESTMP > Typo: TIMESTAMP Done http://gerrit.cloudera.org:8080/#/c/21961/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaMinMaxAggFunction.java@45 PS3, Line 45: return ImpalaTypeConverter.getRelDataType(Type.BOOLEAN); > Why would the Min/Max of a NULL type return a Boolean ? Is this what Impal Having NULL return boolean allows a specific test to pass. http://gerrit.cloudera.org:8080/#/c/21961/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaMinMaxAggFunction.java@58 PS3, Line 58: return callBinding.getOperandType(0).getSqlTypeName().equals(SqlTypeName.TIMESTAMP) > It wasn't clear why this is checking for TIMESTAMP even though the inferRet The inferReturnType for timestamp is able to return a timestamp. I'd imagine it's because it just returns the parameter. But the base Calcite implementation doesn't handle TIMESTAMP. Having said that, I added the explicit case in the inferReturnType method. -- To view, visit http://gerrit.cloudera.org:8080/21961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I038127d6a2f228ae8d263e983b1906e99ae05f77 Gerrit-Change-Number: 21961 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 22 Oct 2024 22:16:46 +0000 Gerrit-HasComments: Yes
