Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21955 )
Change subject: IMPALA-13465: Trace TupleId further to reduce Agg cardinality ...................................................................... Patch Set 3: (2 comments) ps3 narrow down the search across children ScanNodes only. http://gerrit.cloudera.org:8080/#/c/21955/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/21955/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@327 PS2, Line 327: Descriptor sd = s > nit. can use short term "sd" Done http://gerrit.cloudera.org:8080/#/c/21955/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@331 PS2, Line 331: getColumn() != nu > nit. can use short term "sd" Done -- To view, visit http://gerrit.cloudera.org:8080/21955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11f59ccc469c24c1800abaad3774c56190306944 Gerrit-Change-Number: 21955 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 21 Oct 2024 17:24:07 +0000 Gerrit-HasComments: Yes
