Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21955 )
Change subject: IMPALA-13465: Trace TupleId further to reduce Agg cardinality ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21955/1/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/21955/1/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@316 PS1, Line 316: private static @Nullable TupleId findSourceTupleId(Expr expr) { > Why do we now need to check that getParent is not null? Move this check to branches below where getParent() must not null. Change the method into loop instead of recursive. http://gerrit.cloudera.org:8080/#/c/21955/1/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@322 PS1, Line 322: > nit: assigning to another variable here is redundant, the return type is cl Done -- To view, visit http://gerrit.cloudera.org:8080/21955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11f59ccc469c24c1800abaad3774c56190306944 Gerrit-Change-Number: 21955 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 18 Oct 2024 22:11:59 +0000 Gerrit-HasComments: Yes
