Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21729 )
Change subject: IMPALA-13185: Include runtime filter source in key ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/21729/13/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/21729/13/fe/src/main/java/org/apache/impala/planner/PlanNode.java@1387 PS13, Line 1387: LOG.trace("Hash for {}: {}", this, tupleCacheInfo_.getHashTrace()); > getHashTrace() throws an error if the tupleCacheInfo_ is ineligible, and th This is from testing with this and the IMPALA-13181 change to make limits ineligible. It might only happen with both. I think we could add a check immediately after incorporating the runtime filters to see if the runtime filters made us ineligible. If they did, then we can bail out early before doing thrift serialization on this plan node. -- To view, visit http://gerrit.cloudera.org:8080/21729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0077964be5acdb588d76251a6a39e57a0f42bb5a Gerrit-Change-Number: 21729 Gerrit-PatchSet: 13 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 02 Oct 2024 20:48:18 +0000 Gerrit-HasComments: Yes
