Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21729 )
Change subject: IMPALA-13185: Include runtime filter source in key ...................................................................... Patch Set 13: Code-Review+1 (1 comment) This is looking good to me. Unless there are other comments, I will go to +2 http://gerrit.cloudera.org:8080/#/c/21729/9/fe/src/main/java/org/apache/impala/planner/TupleCacheInfo.java File fe/src/main/java/org/apache/impala/planner/TupleCacheInfo.java: http://gerrit.cloudera.org:8080/#/c/21729/9/fe/src/main/java/org/apache/impala/planner/TupleCacheInfo.java@228 PS9, Line 228: } : if (orig.isSetSplit_specs()) { : f > That didn't trigger partition spec. It did expose that reloading partitions The TFileSplitGeneratorSpec code would be tested on s3. I don't think there is a way to cover it with HDFS. -- To view, visit http://gerrit.cloudera.org:8080/21729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0077964be5acdb588d76251a6a39e57a0f42bb5a Gerrit-Change-Number: 21729 Gerrit-PatchSet: 13 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 02 Oct 2024 19:50:16 +0000 Gerrit-HasComments: Yes
