Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21662 )
Change subject: IMPALA-12758: Event processor is ignoring the prev_id while reloading existing partitions ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/21662/4/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/21662/4/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@876 PS4, Line 876: /** : * Returns a string of the form part_key1=value1/part_key2=value2... : > Do we use this somewhere? No, it is not being used after the latest patchset. I'll remove it. http://gerrit.cloudera.org:8080/#/c/21662/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/21662/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@3036 PS4, Line 3036: public void reloadPartitions(IMetaStoreClient client, > If you check the call graphs of this method, you'll see it's not just used Ack, Added a test for the same. http://gerrit.cloudera.org:8080/#/c/21662/1/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/21662/1/tests/custom_cluster/test_events_custom_configs.py@1310 PS1, Line 1310: @pytest.mark.execute_serially > Should we test on local-catalog mode? 'prev_id' of HdfsPartition is not use Ack http://gerrit.cloudera.org:8080/#/c/21662/1/tests/custom_cluster/test_events_custom_configs.py@1324 PS1, Line 1324: self.client.execute("select * from {}".format(test_tbl)) > Post an idea of how to add a test in another comment In the local catalog mode, I have created a partitioned table and loaded the table metadata in the catalog and coordinator. Then I inserted some partition values from Hive and when the event processor processed these partitions, I verified that stale partition metadata is invalidated in the coordinator by looking at the coordinator logs. -- To view, visit http://gerrit.cloudera.org:8080/21662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7d53f601b63d83e99cbd2d1f58076a0dc78c610 Gerrit-Change-Number: 21662 Gerrit-PatchSet: 5 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 02 Oct 2024 18:35:58 +0000 Gerrit-HasComments: Yes
