Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21662 )
Change subject: IMPALA-12758: Fix catalogd not setting prev_id for reloaded partitions ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/21662/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21662/6//COMMIT_MSG@12 PS6, Line 12: coordina > nit: To be clear, I think "LocalCatalog mode coordinators" or "coordinators Ack http://gerrit.cloudera.org:8080/#/c/21662/6//COMMIT_MSG@18 PS6, Line 18: > nit: Please add "for REFRESH <partition> or updating partitions based on HM Ack http://gerrit.cloudera.org:8080/#/c/21662/6/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/21662/6/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@3094 PS6, Line 3094: if (entry.getValue() != null) { : dropPartition(entry.getValue(), false); : } : addPartition(entry.getKey().build()); > We always drop and add the partition instance no matter whether the partiti Ack. We update the file metadata before this logic. So we can really skip drop/create if the partitions are same. -- To view, visit http://gerrit.cloudera.org:8080/21662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7d53f601b63d83e99cbd2d1f58076a0dc78c610 Gerrit-Change-Number: 21662 Gerrit-PatchSet: 7 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 16 Oct 2024 17:52:39 +0000 Gerrit-HasComments: Yes
