Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21698 )
Change subject: IMPALA-13186: Tag query option scope for tuple cache ...................................................................... Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/21698/1/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/21698/1/be/src/service/query-options.h@24 PS1, Line 24: > Seems no need Done http://gerrit.cloudera.org:8080/#/c/21698/1/be/src/service/query-options.h@79 PS1, Line 79: TQueryOptionLevel::REGULAR, QueryOptionScope::Results) \ : REMOVED_QUERY_OPT_FN(allow_unsupported_formats, ALLOW_UNSUPPORTED_FORMATS) \ > Here's a scenario: Sure, seems like a reasonable concern. http://gerrit.cloudera.org:8080/#/c/21698/1/be/src/service/query-options.h@405 PS1, Line 405: ionLevel::ADVANCED, Qu > Could this also affect the result? As the mem_limit_executors is QueryOptio I'm not sure. It looked mostly related to whether a query was admitted. http://gerrit.cloudera.org:8080/#/c/21698/1/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/21698/1/be/src/service/query-options.cc@1428 PS1, Line 1428: HashState hash{ > Do you think one line like this is better? Done http://gerrit.cloudera.org:8080/#/c/21698/1/be/src/thirdparty/datasketches/MurmurHash3.h File be/src/thirdparty/datasketches/MurmurHash3.h: http://gerrit.cloudera.org:8080/#/c/21698/1/be/src/thirdparty/datasketches/MurmurHash3.h@91 PS1, Line 91: MURMUR3_FORCE_INLINE void MurmurHash3_x64_128(const void* key, int lenBytes, HashState& out) { > Using MurmurHash3 makes sense. It is ok to make MurmurHash3 more usable for Ack http://gerrit.cloudera.org:8080/#/c/21698/1/be/src/thirdparty/datasketches/MurmurHash3.h@99 PS1, Line 99: > nit. no need space Done -- To view, visit http://gerrit.cloudera.org:8080/21698 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f4802ad9548749cd43df8848b6f46dca3739ae7 Gerrit-Change-Number: 21698 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 29 Aug 2024 22:55:08 +0000 Gerrit-HasComments: Yes
