Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21698 )
Change subject: IMPALA-13186: Tag query option scope for tuple cache ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/21698/1/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/21698/1/be/src/service/query-options.h@24 PS1, Line 24: vector Seems no need http://gerrit.cloudera.org:8080/#/c/21698/1/be/src/service/query-options.h@405 PS1, Line 405: mem_limit_coordinators Could this also affect the result? As the mem_limit_executors is QueryOptionScope::Results, I'll take a closer look at it. http://gerrit.cloudera.org:8080/#/c/21698/1/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/21698/1/be/src/service/query-options.cc@1428 PS1, Line 1428: HashState hash; Do you think one line like this is better? HashState hash = {QUERY_OPTION_HASH_SEED, QUERY_OPTION_HASH_SEED}; http://gerrit.cloudera.org:8080/#/c/21698/1/be/src/service/query-options.cc@1431 PS1, Line 1431: (SCOPE) & QueryOptionScope::Results It seems like the code could potentially support hashing more types in the future. For example, the codegen caching might use a more refined key that combines with the query options, so it can use here to do some similar hasing. However, it's a good to focus on hashing just the results in this patch http://gerrit.cloudera.org:8080/#/c/21698/1/be/src/thirdparty/datasketches/MurmurHash3.h File be/src/thirdparty/datasketches/MurmurHash3.h: http://gerrit.cloudera.org:8080/#/c/21698/1/be/src/thirdparty/datasketches/MurmurHash3.h@99 PS1, Line 99: nit. no need space -- To view, visit http://gerrit.cloudera.org:8080/21698 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f4802ad9548749cd43df8848b6f46dca3739ae7 Gerrit-Change-Number: 21698 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 29 Aug 2024 18:56:00 +0000 Gerrit-HasComments: Yes
