Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21142 )
Change subject: IMPALA-12737: Query columns in workload management tables. ...................................................................... Patch Set 42: (10 comments) http://gerrit.cloudera.org:8080/#/c/21142/40/be/src/service/workload-management-init.cc File be/src/service/workload-management-init.cc: http://gerrit.cloudera.org:8080/#/c/21142/40/be/src/service/workload-management-init.cc@70 PS40, Line 70: > Very good suggestion. I switched the class level internal_server_ variable Ack http://gerrit.cloudera.org:8080/#/c/21142/40/be/src/service/workload-management-init.cc@103 PS40, Line 103: > Done Ack http://gerrit.cloudera.org:8080/#/c/21142/40/be/src/service/workload-management-init.cc@152 PS40, Line 152: > Done Ack http://gerrit.cloudera.org:8080/#/c/21142/40/be/src/service/workload-management-init.cc@354 PS40, Line 354: // concurrently on all coordinators. Running the same create and alter table statements > It's not my favorite approach either. I've looked some into using the cata What happens when it does fail? Do you have to restart the coordinator? Is there a retry, or will one of them succeed eventually? http://gerrit.cloudera.org:8080/#/c/21142/40/be/src/service/workload-management-init.cc@387 PS40, Line 387: if (auto v = KNOWN_VERSIONS.find(target_schema_version); v == KNOWN_VERSIONS.end()) { > Done Ack http://gerrit.cloudera.org:8080/#/c/21142/40/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/21142/40/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@380 PS40, Line 380: registerReferencedColumns(); > Good point, I had forgotten about the profile. Ack http://gerrit.cloudera.org:8080/#/c/21142/40/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@387 PS40, Line 387: selectList_.getItems().stream().filter(elem -> !elem.isStar()) > Good catch, that is an out-of-date comment and has been removed. Ack http://gerrit.cloudera.org:8080/#/c/21142/40/fe/src/test/java/org/apache/impala/planner/ColumnsTest.java File fe/src/test/java/org/apache/impala/planner/ColumnsTest.java: http://gerrit.cloudera.org:8080/#/c/21142/40/fe/src/test/java/org/apache/impala/planner/ColumnsTest.java@68 PS40, Line 68: testColumns(query, "default", select, where, join, aggregate, orderBy); > Done Ack http://gerrit.cloudera.org:8080/#/c/21142/40/tests/custom_cluster/test_workload_mgmt_init.py File tests/custom_cluster/test_workload_mgmt_init.py: http://gerrit.cloudera.org:8080/#/c/21142/40/tests/custom_cluster/test_workload_mgmt_init.py@165 PS40, Line 165: def test_create_on_version_1_1_0(self): > Done Ack http://gerrit.cloudera.org:8080/#/c/21142/40/tests/custom_cluster/test_workload_mgmt_sql_details.py File tests/custom_cluster/test_workload_mgmt_sql_details.py: http://gerrit.cloudera.org:8080/#/c/21142/40/tests/custom_cluster/test_workload_mgmt_sql_details.py@226 PS40, Line 226: ["warehouse.w_warehouse_name", "ship_mode.sm_type", "web_site.web_name"], > Done Ack -- To view, visit http://gerrit.cloudera.org:8080/21142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78f3670b067c0c192ee8a212fba95466fbcb51d7 Gerrit-Change-Number: 21142 Gerrit-PatchSet: 42 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 29 Aug 2024 18:52:58 +0000 Gerrit-HasComments: Yes
