Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21142 )
Change subject: IMPALA-12737: Query columns in workload management tables. ...................................................................... Patch Set 42: (6 comments) http://gerrit.cloudera.org:8080/#/c/21142/41/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/21142/41/be/src/service/impala-server.h@1661 PS41, Line 1661: boost::scoped_ptr<ThriftServer> hs2_http_server_; What maintains the lifetime of the InternalServer? I guess it's always a reference to itself, so it was a circular shared ref? http://gerrit.cloudera.org:8080/#/c/21142/40/be/src/service/workload-management-init.cc File be/src/service/workload-management-init.cc: http://gerrit.cloudera.org:8080/#/c/21142/40/be/src/service/workload-management-init.cc@70 PS40, Line 70: > This shouldn't need to be a shared_ptr. It's not held beyond the lifetime o Done http://gerrit.cloudera.org:8080/#/c/21142/40/be/src/service/workload-management-init.cc@103 PS40, Line 103: > Doesn't need to be a shared_ptr. Done http://gerrit.cloudera.org:8080/#/c/21142/40/be/src/service/workload-management-init.cc@152 PS40, Line 152: > Doesn't need to be a shared_ptr. Done http://gerrit.cloudera.org:8080/#/c/21142/40/be/src/service/workload-management-init.cc@387 PS40, Line 387: if (auto v = KNOWN_VERSIONS.find(target_schema_version); v == KNOWN_VERSIONS.end()) { > Might be nice to list the known versions. Done http://gerrit.cloudera.org:8080/#/c/21142/41/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/21142/41/be/src/service/workload-management.cc@65 PS41, Line 65: static list<CompletedQuery> _completed_queries; What was the argument for moving these out of ImpalaServer and making them global static variables? I'm generally wary of mutable global variables. -- To view, visit http://gerrit.cloudera.org:8080/21142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78f3670b067c0c192ee8a212fba95466fbcb51d7 Gerrit-Change-Number: 21142 Gerrit-PatchSet: 42 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 29 Aug 2024 18:47:25 +0000 Gerrit-HasComments: Yes
