Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21700 )
Change subject: IMPALA-13310 Add the value of the http 'X-Forwarded-For' header to the runtime profile ...................................................................... Patch Set 3: (2 comments) Thanks for the reviews http://gerrit.cloudera.org:8080/#/c/21700/3/be/src/transport/THttpServer.cpp File be/src/transport/THttpServer.cpp: http://gerrit.cloudera.org:8080/#/c/21700/3/be/src/transport/THttpServer.cpp@167 PS3, Line 167: origin_ = value; > I'm OK with addressing it in separate patch. I think this is reasonable, I added IMPALA-13335 http://gerrit.cloudera.org:8080/#/c/21700/3/be/src/transport/THttpServer.cpp@454 PS3, Line 454: callbacks_.set_http_origin_fn(origin_); > This seems redundant? We're setting 'http_origin' 2 times. Good catch, thanks -- To view, visit http://gerrit.cloudera.org:8080/21700 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e010cfb09674c5d043ef915347c3836696e03cf Gerrit-Change-Number: 21700 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 28 Aug 2024 00:33:43 +0000 Gerrit-HasComments: Yes
