Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21700 )
Change subject: IMPALA-13310 Add the value of the http 'X-Forwarded-For' header to the runtime profile ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21700/1/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/21700/1/be/src/rpc/authentication.cc@1438 PS1, Line 1438: callbacks.set_http_origin_fn = std::bind(SetOrigin, connection_ptr.get(), There could be multiple XFF address in the header corresponding to the various intermediate proxies, it seems we include all of them? This is probably okay behavior for logging in query profile. -- To view, visit http://gerrit.cloudera.org:8080/21700 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e010cfb09674c5d043ef915347c3836696e03cf Gerrit-Change-Number: 21700 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 26 Aug 2024 21:01:35 +0000 Gerrit-HasComments: Yes
