Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21541 )
Change subject: IMPALA-12906: Incorporate scan range information into the tuple cache key ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/21541/7/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/21541/7/be/src/scheduling/scheduler.cc@603 PS7, Line 603: if (a_hdfs_split.mtime() != b_hdfs_split.mtime()) { > My point was related to the comment at lines 601-602. This is fine unless w Yeah, the definitions of the accessor functions are in the header file, and the compiler knows everything. Trying out similar code on Godbolt, the code ends up being two memory accesses, one cmp, and a jmp. -- To view, visit http://gerrit.cloudera.org:8080/21541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe298fff0f644ce931a2aa934ebb98f69aab9d34 Gerrit-Change-Number: 21541 Gerrit-PatchSet: 7 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 27 Aug 2024 00:53:54 +0000 Gerrit-HasComments: Yes
