Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21541 )
Change subject: IMPALA-12906: Incorporate scan range information into the tuple cache key ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/21541/6/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/21541/6/be/src/scheduling/scheduler.cc@601 PS6, Line 601: const HdfsFileSplitPB& a_hdfs_split = a.scan_range().hdfs_file_split(); > Good point, changed to look like: Ack http://gerrit.cloudera.org:8080/#/c/21541/6/be/src/scheduling/scheduler.cc@637 PS6, Line 637: /// Helper class used in CreateScanInstances() to track the amount of work assigned > Done Ack http://gerrit.cloudera.org:8080/#/c/21541/7/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/21541/7/be/src/scheduling/scheduler.cc@593 PS7, Line 593: if (a_weight != b_weight) { nit: Could be a one-liner. As could the assignment above. http://gerrit.cloudera.org:8080/#/c/21541/7/be/src/scheduling/scheduler.cc@603 PS7, Line 603: if (a_hdfs_split.mtime() != b_hdfs_split.mtime()) { If these get more expensive to compute, do we really want to repeat them for every expression? -- To view, visit http://gerrit.cloudera.org:8080/21541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe298fff0f644ce931a2aa934ebb98f69aab9d34 Gerrit-Change-Number: 21541 Gerrit-PatchSet: 7 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 20 Aug 2024 20:58:47 +0000 Gerrit-HasComments: Yes
