Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21596 )
Change subject: IMPALA-12576: Display warning on the query timeline page for the experimental profile ...................................................................... Patch Set 2: Currently, the "collectFragmentEventsFromProfile" method is too large for implementing a test, while mocking the entire surrounding variables and environment. But, there are already tests written for functions parsing the profile and collecting metrics here. https://gerrit.cloudera.org/c/20538/ Using JEST testing framework to test this would be difficult as I mentioned. It might be possible to add python webUI tests. -- To view, visit http://gerrit.cloudera.org:8080/21596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ad62be3572b7a126ce10dc4a11fcc9b8a58013d Gerrit-Change-Number: 21596 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Thu, 22 Aug 2024 10:31:11 +0000 Gerrit-HasComments: No
