Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21596 )
Change subject: IMPALA-12576: Display warning on the query timeline page for the experimental profile ...................................................................... Patch Set 2: (1 comment) Thank you for your comments. Please let me know if any other changes are required http://gerrit.cloudera.org:8080/#/c/21596/2/www/scripts/query_timeline/fragment_diagram.js File www/scripts/query_timeline/fragment_diagram.js: http://gerrit.cloudera.org:8080/#/c/21596/2/www/scripts/query_timeline/fragment_diagram.js@169 PS2, Line 169: resizeTimingDiagramWarning > I think the height can be adjusted as well. It looks too high right now wit The height is not being controlled here. It is actually part of the 'displayWarning' function. It was kept as '200px' as it was the minimum height for all charts on the page, also for other reasons related to resizing. Please let me know if it has other implications. -- To view, visit http://gerrit.cloudera.org:8080/21596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ad62be3572b7a126ce10dc4a11fcc9b8a58013d Gerrit-Change-Number: 21596 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Thu, 01 Aug 2024 06:53:38 +0000 Gerrit-HasComments: Yes
