Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21679 )
Change subject: IMPALA-13302: Analyze new rewrite exprs ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21679/4/fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java File fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java: http://gerrit.cloudera.org:8080/#/c/21679/4/fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java@95 PS4, Line 95: rewrittenExpr.analyze(analyzer); Please add comment in ExprRewriteRule.apply() to remind caller to reanalyze the rewritten expression. -- To view, visit http://gerrit.cloudera.org:8080/21679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6be731c2ea79c96e51d199c822e2cb34e5bb3028 Gerrit-Change-Number: 21679 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 20 Aug 2024 00:37:15 +0000 Gerrit-HasComments: Yes
