Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21679 )
Change subject: IMPALA-13302: Analyze new rewrite exprs ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21679/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/21679/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@3352 PS1, Line 3352: conjunct.getId() == null > Is it ok the get null here? It is hard for me to imagine what that exactly I saw it happen. Not sure why, I can dig into it more. It does seem like a mistake, and any additional behavior in this function seems accidental. -- To view, visit http://gerrit.cloudera.org:8080/21679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6be731c2ea79c96e51d199c822e2cb34e5bb3028 Gerrit-Change-Number: 21679 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 16 Aug 2024 17:25:27 +0000 Gerrit-HasComments: Yes
