Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/21593 )
Change subject: IMPALA-13233: Represent phases of each instance separately on the query timeline ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/21593/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21593/3//COMMIT_MSG@7 PS3, Line 7: IMPALA-13233: Represent phases of each instance separately on the query timeline Improve display of instance-level skew in query timeline http://gerrit.cloudera.org:8080/#/c/21593/3//COMMIT_MSG@16 PS3, Line 16: being shown parallelly aggregated and displayed as a histogram http://gerrit.cloudera.org:8080/#/c/21593/3//COMMIT_MSG@21 PS3, Line 21: are bucketed into 4 groups. Each group's timestamps are averaged and The histogram should display the min/max values somehow sicne averages can be very misleading with outliers. http://gerrit.cloudera.org:8080/#/c/21593/3/www/scripts/query_timeline/fragment_diagram.js File www/scripts/query_timeline/fragment_diagram.js: http://gerrit.cloudera.org:8080/#/c/21593/3/www/scripts/query_timeline/fragment_diagram.js@263 PS3, Line 263: if (dx > ignore_px) { With the bucketed display, there is no good reason to skip displaying small skews. That was done previously because they could not be rendered. -- To view, visit http://gerrit.cloudera.org:8080/21593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied8a5966e9e4111bf7aa25aee11d23881daad7d2 Gerrit-Change-Number: 21593 Gerrit-PatchSet: 3 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 15 Aug 2024 15:21:45 +0000 Gerrit-HasComments: Yes
