Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21593 )
Change subject: IMPALA-13233: Represent phases of each instance separately on the query timeline ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/21593/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21593/2//COMMIT_MSG@20 PS2, Line 20: When there are more than 4 instances for a phase, respective timestamps : are bucketed into 4 groups. Each group's timestamps are averaged and : then displayed on the timeline. How is bucketing done here? Are they sorted first? I just remember one thing: When MT_DOP > 0 or COMPUTE_PROCESSING_COST=True, there can be multiple instances of same fragment running in single host. If num host is small and these query option exist in profile, it is probably OK to group them based on hostname where they're run. It will better highlight group of instances that run in one host vs the other host. http://gerrit.cloudera.org:8080/#/c/21593/2/www/scripts/query_timeline/fragment_diagram.js File www/scripts/query_timeline/fragment_diagram.js: http://gerrit.cloudera.org:8080/#/c/21593/2/www/scripts/query_timeline/fragment_diagram.js@167 PS2, Line 167: events Can you put diagram/comment on how the structure of this events list is? It is not obvious to me what is events[x].parts, event[x].tslist, etc. http://gerrit.cloudera.org:8080/#/c/21593/2/www/scripts/query_timeline/fragment_diagram.js@202 PS2, Line 202: if (events[0].no_bar === undefined) { Why events[0] is handled separately from other at L238? Are the codes repeated here and there? -- To view, visit http://gerrit.cloudera.org:8080/21593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied8a5966e9e4111bf7aa25aee11d23881daad7d2 Gerrit-Change-Number: 21593 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 30 Jul 2024 20:56:17 +0000 Gerrit-HasComments: Yes
