Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21675 )
Change subject: IMPALA-13296: Check column compatibility earlier for table migration ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21675/1/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java File fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java: http://gerrit.cloudera.org:8080/#/c/21675/1/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java@130 PS1, Line 130: IcebergSchemaConverter.convertToIcebergSchema(table.getMetaStoreTable()); > Is it possible to somehow save the converted schema if there's no error dur We could, but for that we'd need to convert them to thrift or such, send them back and forth between FE and BE so that we can pass it from the analyzer to CatalogOpExecutor. And then we'd need to convert that intermediary format again to Iceberg schema anyway on the receiver's end. Since it's a cheap process to convert the schema, I think we can save the code for this and simply do the schema conversion twice. -- To view, visit http://gerrit.cloudera.org:8080/21675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I381e7359a55ebd84f9a1dcec3b665bdbea62a035 Gerrit-Change-Number: 21675 Gerrit-PatchSet: 1 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 15 Aug 2024 13:48:47 +0000 Gerrit-HasComments: Yes
