Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/21675 )
Change subject: IMPALA-13296: Check column compatibility earlier for table migration ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Looks good, thank you Gabor! http://gerrit.cloudera.org:8080/#/c/21675/1/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java File fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java: http://gerrit.cloudera.org:8080/#/c/21675/1/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java@130 PS1, Line 130: IcebergSchemaConverter.convertToIcebergSchema(table.getMetaStoreTable()); Is it possible to somehow save the converted schema if there's no error during the conversion? If it's possible, we could avoid doing the conversion twice. -- To view, visit http://gerrit.cloudera.org:8080/21675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I381e7359a55ebd84f9a1dcec3b665bdbea62a035 Gerrit-Change-Number: 21675 Gerrit-PatchSet: 1 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 15 Aug 2024 12:59:13 +0000 Gerrit-HasComments: Yes
